Mine ar HO but if you care to look at http://www.xdford.digitalzones.com/modelrr11.htm, you can see how mine were "recycled" There is no reason to just use styrene sheet and paint a visor on the LED similar to what I have done for my searchlight signals http://www.xdford.digitalzones.com/construction of a model railway signal.htm for your larger scales.
Your efforts look OK as well!
Cheers from Australia
Trevor
Nice work I've seen where some LED manufactures make em with 90 degree mounts and some enterprising guys have used them for HO dwarf signals wish I would have known that before I spent a nice sum on Tomar and NJ dwarfs
Since I use DC switch machines to power my switches (3-rail GarGraves) I decided to use the DC current polarity to power a red/green LED. I used some scrap tubing and here is the result.
Red and green indications of the switch setting.