If the decoder is a good one (Soundtraxx, LOK, QSI, or other GOOD decoder (not MRC)), and it has been installed correctly with no exposed bare wires, they should last almost forever.
If you are having trouble with your decoders smoking after you install them, you may be doing something wrong. If you can't find out what, it may be worth having them installed professionally.